Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved top lang fetching & changed title #240

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

anuraghazra
Copy link
Owner

This Fix improves the top languages card's stats by instead of counting only the first language returned from repos it counts all the languages in a repo.

fixes #136

Also checkout my this comment #136 (comment)

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #240 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   95.20%   95.18%   -0.03%     
==========================================
  Files          15       15              
  Lines         417      415       -2     
  Branches      122      122              
==========================================
- Hits          397      395       -2     
  Misses         16       16              
  Partials        4        4              
Impacted Files Coverage Δ
src/fetchTopLanguages.js 100.00% <100.00%> (ø)
src/renderTopLanguages.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f8ee7...826f020. Read the comment docs.

@anuraghazra anuraghazra merged commit f741ec0 into master Jul 28, 2020
@anuraghazra anuraghazra deleted the fix-lang-stats branch October 31, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top Languages Card not working properly
1 participant