-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update imgui to 1.72b #288
Conversation
Is there a checklist of remaining things for this, or something? |
What changes were made to anura.vcxproj? I made some a few days ago to skip a few libraries we weren't using, like Box2D. |
There are only 44 changes: 29 additions and 15 deletions. |
Diffview wasn't being very helpful, so I just merged the longer one with the if statement in it. |
Hm, I evidently did that workflow wrong. I've reverted my merge into master, because it threw a lot of errors at me on Linux. I should have checked out the branch and tested it there. Something for next time, I guess. Here are the errors blocking me on Ubuntu: https://gist.github.com/DDR0/7f347a9c596f6bb6ad6f29390f35fb78 |
simplify your life by checking stuff before mergning instead of after. When possible, have others do those checks for you. Consider also using bots too |
Aye, having a build server would be nice.
…On Sat., Aug. 15, 2020, 6:27 a.m. galegosimpatico, ***@***.***> wrote:
simplify your life by checking stuff before mergning
<#288 (comment)>
instead of after. When possible, have others do those checks for you.
Consider also using bots too
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGSTI47AUI2DGPWFLJU6MLSA2EM7ANCNFSM4IIMNXKQ>
.
|
No description provided.