Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit debug console size to current window size. #251

Merged
2 commits merged into from Mar 24, 2018
Merged

Limit debug console size to current window size. #251

2 commits merged into from Mar 24, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2018

If any stored preferences for the debug console size happens to be larger than its corresponding dimension at the current window size, ignore the preference and create the debug console panel using the window size values instead of the stored preferences.

I prepared this one today... originally to be directly pushed to trunk. But I'm rather creating a pull request for it because maybe it is better to wait some days or weeks before adding low importance changes.

If any stored preferences for the debug console size happens to be
larger than its corresponding dimension at the current window size,
ignore the preference and create the debug console _panel_ using the
window size values instead of the stored preferences.
@ghost
Copy link
Author

ghost commented Mar 8, 2018

I would be merging this by myself as soon as am sure the imgui upgrade is safe... I had some problems on my Debian box after it was applied... so I opened this anura-engine/imgui#2 pull request just in case, but I hope it's my fault.

src/debug_console.cpp: Replace ternary operator with more (idiomatic?)
clamp call.
@ghost ghost merged commit 9b17aad into anura-engine:trunk Mar 24, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant