Allow negative logic for the is operator.
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where the `variable is type` construct is allowed, allow the `variable is not type` construct too.
davewx7
requested changes
Nov 26, 2017
src/formula.cpp
Outdated
| @@ -4773,6 +4779,11 @@ static std::string debugSubexpressionTypes(ConstFormulaPtr & fml) | |||
| int consume_backwards = 0; | |||
| std::string op_name(op->begin,op->end); | |||
|
|
|||
| if (op_name == "is" && op > i1 && op + 1 > i1 && | |||
There was a problem hiding this comment.
You don't need to check op + 1 > i1 since op > i1 already guarantees this, however you should check that op + 1 < i2 before using op + 1 to make sure we don't run off the end of the buffer.
The program would be incurring in an illegal memory access when trying to parse formulae such as e.g. `x is`. Greetings to David White for seeing the crash coming. ^^U
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
variable is typeconstruct is allowed, allow thevariable is not typeconstruct too.Please handle this with the required care and calm... but I think it should be mostly alright.
Safety:
frogattonot checked,citadelbooting,anuratests passing.Cheers and Regards,