Bring back (under certain conditions) the off line mode to the splash screen. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring back the off line mode to the splash screen, now only meant to be used when the developer mode is enabled. It is not that anyone looking for a game is going to interrupt developers, it is to provide developers the option to abstract themselves without resorting to cutting network access at an operating system level.
Adapt the 'tictactoe' module to rev 'Bring back the off line mode to the splash screen (rev 2bcabe5)'. Make sure the 'tictactoe' module is showing the now come back 'Play Offline' button, while making sure in AA only shows up when the developer tools are requested.
When there are six buttons instead of five, they have to be closer to each one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
galegosimpatico@2bcabe5 intends to reconfigure
anurato show the Play Offline interface in the game splash screen coupled with the Devtools interface showing in the lobby. From the rev commit message:galegosimpatico@2a9c896 intends to make sure in the
tictactoemodule that new (old) button is always present.That has an UI undesired side effect.
Windowed
tictactoe. Note the lowest button (Exit Game) is wrong, it is unreachable:Full screen
tictactoeis ugly but acceptable:Full screen AA is OK:
In windowed AA the lowest button is wrong:
In order to fix this, galegosimpatico@1193c28 intends to reposition the buttons, some captures follow.
Full screen
tictactoeis now better:Windowed
tictactoeis now acceptable:Windowed AA is OK:
Full screen AA is OK as well:
Cheers and Regards,
EDIT: Fixed lots of mistakes in picture captions, they were all wrong.