Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not count references to decimal variants. #189

Merged
merged 1 commit into from Sep 25, 2017
Merged

Do not count references to decimal variants. #189

merged 1 commit into from Sep 25, 2017

Conversation

uprego
Copy link

@uprego uprego commented Sep 24, 2017

At branch 'dev-no-decimal-refcount-mgmt'.

Given decimal typed variants are immutable - at least they very
probably they should, and that is congruent with the inner code of the
functions releasing and increasing reference counts
('variant::release()' and 'variant::increment_refcount()',
respectively); do not use unnecesarily the reference count management
sources on them, for a symbolic performance increase and an increased
harmony of the sources.

Changes are somewhat fine grain and self evident, but even though,
this commit is specifically passing the Anura automated test suite,
and both Frogatto and Argentum Age seem to be mostly OK with these
changes.

Cheers and regards,

At branch 'dev-no-decimal-refcount-mgmt'.

Given decimal typed variants are immutable - at least they very
probably they should, and that is congruent with the inner code of the
functions releasing and increasing reference counts
('variant::release()' and 'variant::increment_refcount()',
respectively); do not use unnecesarily the reference count management
sources on them, for a symbolic performance increase and an increased
harmony of the sources.

Changes are somewhat fine grain and self evident, but even though,
this commit is specifically passing the Anura automated test suite,
and both Frogatto and Argentum Age seem to be mostly OK with these
changes.
@davewx7 davewx7 merged commit 6dda489 into anura-engine:trunk Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants