Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 为interval添加最小高度配置 #5715

Merged
merged 10 commits into from
Nov 7, 2023

Conversation

iamzone
Copy link
Contributor

@iamzone iamzone commented Nov 1, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

Fiexs #5686
Interval shape 增加 minHeight 最小高度的配置

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@iamzone
Copy link
Contributor Author

iamzone commented Nov 1, 2023

line

@Runtus
Copy link
Contributor

Runtus commented Nov 2, 2023

hi老哥,你这里的柱状图的最小值是倒着渲染的,我那里改了一版把这个修复了,不知道是否能给你的fork仓库提一个PR

@iamzone
Copy link
Contributor Author

iamzone commented Nov 2, 2023

hi老哥,你这里的柱状图的最小值是倒着渲染的,我那里改了一版把这个修复了,不知道是否能给你的fork仓库提一个PR

可以的

Runtus and others added 3 commits November 2, 2023 16:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: fix the inverted rect display

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考这个 PR #5123 添加:

  • 测试案例
  • 文档
  • Demo

目前没有去测水平情况。

src/shape/interval/color.ts Outdated Show resolved Hide resolved
src/shape/interval/color.ts Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Runtus Runtus mentioned this pull request Nov 3, 2023
3 tasks
Runtus and others added 2 commits November 3, 2023 20:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Interval min height
@pearmini
Copy link
Member

pearmini commented Nov 6, 2023

代码格式存在一些问题,运行一下:npm run fix 再提交。

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大部分都没有问题了,还有两点需要一下:

  • 运行 npm run lint
  • 去掉 maxHeight 的类型定义

src/shape/interval/rect.ts Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: cancel the maxHeight type and format the code style
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearmini pearmini merged commit bbfad52 into antvis:v5 Nov 7, 2023
2 of 3 checks passed
@pearmini
Copy link
Member

pearmini commented Nov 7, 2023

@iamzone @Runtus 这个任务的完成质量还是很不错的!期待你们参与更多的贡献:https://github.com/orgs/antvis/projects/25

Exlau pushed a commit to Exlau/G2 that referenced this pull request Nov 10, 2023
* fix: 为interval添加最小高度配置

* fix: fix the inverted rect display

* fix: fit horizontal direction minHeight, and change code style

* fix: add minHeight test

* fix: add snapshot

* fix: cancel the maxHeight type and format the code style

---------

Co-authored-by: Runtus <893119806@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants