-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 为interval添加最小高度配置 #5715
fix: 为interval添加最小高度配置 #5715
Conversation
hi老哥,你这里的柱状图的最小值是倒着渲染的,我那里改了一版把这个修复了,不知道是否能给你的fork仓库提一个PR |
可以的 |
fix: fix the inverted rect display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interval min height
代码格式存在一些问题,运行一下: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大部分都没有问题了,还有两点需要一下:
- 运行
npm run lint
- 去掉
maxHeight
的类型定义
fix: cancel the maxHeight type and format the code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iamzone @Runtus 这个任务的完成质量还是很不错的!期待你们参与更多的贡献:https://github.com/orgs/antvis/projects/25 |
* fix: 为interval添加最小高度配置 * fix: fix the inverted rect display * fix: fit horizontal direction minHeight, and change code style * fix: add minHeight test * fix: add snapshot * fix: cancel the maxHeight type and format the code style --------- Co-authored-by: Runtus <893119806@qq.com>
Checklist
npm test
passesDescription of change
Fiexs #5686
Interval shape 增加 minHeight 最小高度的配置