fix: 为interval添加最小高度配置 #5715
Merged
fix: 为interval添加最小高度配置 #5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
|
hi老哥，你这里的柱状图的最小值是倒着渲染的，我那里改了一版把这个修复了，不知道是否能给你的fork仓库提一个PR |
可以的 |
fix: fix the inverted rect display
pearmini
requested changes
Nov 3, 2023
Interval min height
|
代码格式存在一些问题，运行一下： |
pearmini
requested changes
Nov 6, 2023
4 tasks
fix: cancel the maxHeight type and format the code style
4 tasks
|
@iamzone @Runtus 这个任务的完成质量还是很不错的！期待你们参与更多的贡献：https://github.com/orgs/antvis/projects/25 |
Exlau
pushed a commit
to Exlau/G2
that referenced
this pull request
Nov 10, 2023
* fix: 为interval添加最小高度配置 * fix: fix the inverted rect display * fix: fit horizontal direction minHeight, and change code style * fix: add minHeight test * fix: add snapshot * fix: cancel the maxHeight type and format the code style --------- Co-authored-by: Runtus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
Fiexs #5686
Interval shape 增加 minHeight 最小高度的配置