fix: 修复明细表自定义列头时, 隐藏列头后出现空白区域 close #3044 #3046
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
你好 @lijinke666，非常感谢你的贡献. Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Walkthrough此PR修复了在明细表自定义列头时，隐藏列头后出现空白区域的问题。通过重新计算父级节点的宽度和x坐标，确保隐藏列头后布局正确。添加了相关的单元测试和文档说明。 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -8,7 +8,7 @@ import ora from 'ora'; | |||
| inquirer.registerPrompt('autocomplete', autoCompletePrompt); | |||
|
|
|||
| function run(path) { | |||
| const command = `cross-env DEBUG_MODE=1 npx jest ${path} --passWithNoTests`; | |||
| const command = `cross-env DEBUG_MODE=1 npx jest ${path} --passWithNoTests --detectOpenHandless`; | |||
There was a problem hiding this comment.
There seems to be a typo in the option --detectOpenHandless. It should be --detectOpenHandles.
| (childNode) => childNode.width, | ||
| ); | ||
| // 父节点 x 坐标 = 第一个未隐藏的子节点的 x 坐标 | ||
| const parentNodeX = firstVisibleChildNode?.x || 0; |
There was a problem hiding this comment.
没有任何改动, 移动到 base-facet, 给明细表复用, 多列头下隐藏透视表之前修复过, 现在保持两边逻辑统一
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3046 +/- ##
==========================================
Coverage 75.77% 75.77%
==========================================
Files 257 51 -206
Lines 11994 1490 -10504
Branches 2464 284 -2180
==========================================
- Hits 9088 1129 -7959
+ Misses 1398 210 -1188
+ Partials 1508 151 -1357 ☔ View full report in Codecov by Sentry. |
|
Size Change: -59 B (-0.01%) Total Size: 618 kB
ℹ️ View Unchanged
|
|
🎉 This PR is included in version @antv/s2-v2.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @antv/s2-react-v2.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge