Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复数值单元格 tooltip 内的指标名展示错误 #2941

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 24, 2024 10:18am

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Oct 24, 2024
Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 330 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.8 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.96 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (ecdc9c8) to head (e7c6312).
Report is 453 commits behind head on next.

Files with missing lines Patch % Lines
packages/s2-core/src/utils/tooltip.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2941      +/-   ##
==========================================
+ Coverage   75.77%   80.80%   +5.03%     
==========================================
  Files         257      180      -77     
  Lines       11994    10427    -1567     
  Branches     2464     2366      -98     
==========================================
- Hits         9088     8426     -662     
+ Misses       1398      554     -844     
+ Partials     1508     1447      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit a426a46 into next Oct 25, 2024
12 of 13 checks passed
@wjgogogo wjgogogo deleted the fix-tooltip-measure-name branch October 25, 2024 07:21
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants