-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 导出组件支持复制 HTML (text/html) 格式的数据 close #2828 #2865
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +47 B (+0.01%) Total Size: 329 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2865 +/- ##
==========================================
+ Coverage 75.77% 80.81% +5.03%
==========================================
Files 257 180 -77
Lines 11994 10412 -1582
Branches 2464 2360 -104
==========================================
- Hits 9088 8414 -674
+ Misses 1398 553 -845
+ Partials 1508 1445 -63 ☔ View full report in Codecov by Sentry. |
|
||
return data; | ||
}; | ||
|
||
const getPlainData = async (split: string, isFormat: boolean) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
复制写入 text/plain
和 text/html
导出写入 text/plain
formatOptions: true, | ||
}); | ||
*/ | ||
export const asyncGetAllHtmlData = async (params: CopyAllDataParams) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有点纠结叫 asyncGetAllHTMLData
还是 asyncGetAllHtmlData
, 前者更符合规范, 后者更符合风格一致性
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还是叫后者好了, XMLHttpRequest
也是类似 Http
🎉 This PR is included in version @antv/s2-v2.0.0-next.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v2.0.0-next.26 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
✨ Feature
📝 Description
asyncGetAllPlainData
的基础上, 透出asyncGetAllHtmlData
和asyncGetAllData
, 适配不同场景, 供开发者自由选择🖼️ Screenshot
🔗 Related issue link
closes #2828 #2873
🔍 Self-Check before the merge