Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 构建编译到 es2015, 修复空值合并运算符导致编译失败的问题 close #2585 #2550 #2587

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Mar 8, 2024

👀 PR includes

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other (build)

📝 Description

Vite 默认的 target 是 ['es2020', 'edge88', 'firefox78', 'chrome87', 'safari14'], 不会编译 ?? , 修改为 'es2015'

🖼️ Screenshot

Before After
image image

🔗 Related issue link

closes #2585 #2550

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Mar 8, 2024 8:42am

@github-actions github-actions bot requested review from wjgogogo and wuhaiyang March 8, 2024 07:46
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Size Change: +826 B (0%)

Total Size: 318 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 222 kB +187 B (0%)
./packages/s2-react/dist/index.min.js 69.3 kB +586 B (+1%)
./packages/s2-react/dist/style.min.css 4 kB -12 B (0%)
./packages/s2-vue/dist/index.min.js 20.3 kB +77 B (0%)
./packages/s2-vue/dist/style.min.css 1.97 kB -12 B (-1%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B

compressed-size-action

@lijinke666 lijinke666 merged commit db039d0 into next Mar 8, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the chore-build branch March 8, 2024 08:59
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Mar 8, 2024
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-vue-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants