Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: frozenRowCell 重命名为 rowCell #2450

Merged
merged 4 commits into from
Dec 5, 2023

fix: 修复行头滚动刷选获取到错误的实例

3006ab3
Select commit
Loading
Failed to load commit list.
Merged

refactor: frozenRowCell 重命名为 rowCell #2450

fix: 修复行头滚动刷选获取到错误的实例
3006ab3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2023 in 0s

76.62% (+0.13%) compared to 1adc25d

View this Pull Request on Codecov

76.62% (+0.13%) compared to 1adc25d

Details

Codecov Report

Attention: 208 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (3006ab3) 76.62%.
Report is 104 commits behind head on master.

Files Patch % Lines
packages/s2-core/src/cell/base-row-cell.ts 71.72% 22 Missing and 19 partials ⚠️
packages/s2-core/src/facet/frozen-facet.ts 82.58% 2 Missing and 33 partials ⚠️
packages/s2-core/src/facet/pivot-facet.ts 79.38% 3 Missing and 17 partials ⚠️
packages/s2-core/src/data-set/pivot-data-set.ts 72.85% 2 Missing and 17 partials ⚠️
packages/s2-core/src/utils/text.ts 42.85% 7 Missing and 1 partial ⚠️
...ckages/s2-core/src/facet/header/base-frozen-row.ts 85.36% 0 Missing and 6 partials ⚠️
...eraction/base-interaction/click/data-cell-click.ts 50.00% 3 Missing and 3 partials ⚠️
...mponents/sheets/editable-sheet/edit-cell/index.tsx 50.00% 5 Missing and 1 partial ⚠️
...s/s2-core/src/facet/layout/build-gird-hierarchy.ts 85.29% 1 Missing and 4 partials ⚠️
packages/s2-core/src/facet/layout/layout-hooks.ts 0.00% 3 Missing and 1 partial ⚠️
... and 33 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2450      +/-   ##
==========================================
+ Coverage   76.48%   76.62%   +0.13%     
==========================================
  Files         240      246       +6     
  Lines       12312    12765     +453     
  Branches     2630     2750     +120     
==========================================
+ Hits         9417     9781     +364     
+ Misses       1377     1367      -10     
- Partials     1518     1617      +99

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov