-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 自定义 svg 支持无后缀的在线链接 #2065
fix: 自定义 svg 支持无后缀的在线链接 #2065
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -10 B (0%) Total Size: 435 kB
ℹ️ View Unchanged
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
Codecov ReportBase: 77.16% // Head: 76.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 77.16% 76.65% -0.52%
==========================================
Files 234 240 +6
Lines 11518 12233 +715
Branches 2449 2606 +157
==========================================
+ Hits 8888 9377 +489
- Misses 1258 1361 +103
- Partials 1372 1495 +123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
🎉 This PR is included in version @antv/s2-v1.41.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix: 自定义 svg 支持无后缀的在线链接 * test: 修复测试
👀 PR includes
🐛 Bugfix
🔧 Chore
📝 Description
customSVGIcons
支持在线链接, 但是直接判断的链接后缀有些 CDN 提供的链接是不带后缀的, 即根据 content-type 渲染, 故 svg 不能正常渲染
如: https://mdn.alipayobjects.com/huamei_qa8qxu/afts/img/A*5nsESLuvc_EAAAAAAAAAAAAADmJ7AQ/original
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge