Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 自定义 svg 支持无后缀的在线链接 #2065

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

customSVGIcons 支持在线链接, 但是直接判断的链接后缀

image

有些 CDN 提供的链接是不带后缀的, 即根据 content-type 渲染, 故 svg 不能正常渲染

const s2Options = {
  customSVGIcons: [
    {
      name: 'testIcon',
      svg: 'https://mdn.alipayobjects.com/huamei_qa8qxu/afts/img/A*5nsESLuvc_EAAAAAAAAAAAAADmJ7AQ/original',
    },
  ],
  headerActionIcons: [
    {
      iconNames: ['testIcon'],
      belongsCell: 'rowCell',
    },
  ],
}

如: https://mdn.alipayobjects.com/huamei_qa8qxu/afts/img/A*5nsESLuvc_EAAAAAAAAAAAAADmJ7AQ/original

image

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
antvis-s2 ❌ Failed (Inspect) Feb 7, 2023 at 8:20AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Size Change: -10 B (0%)

Total Size: 435 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 171 kB -10 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 67.4 kB
./packages/s2-react/dist/style.min.css 3.43 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 77.16% // Head: 76.65% // Decreases project coverage by -0.52% ⚠️

Coverage data is based on head (7f572d7) compared to base (a4b14a8).
Patch coverage: 67.99% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   77.16%   76.65%   -0.52%     
==========================================
  Files         234      240       +6     
  Lines       11518    12233     +715     
  Branches     2449     2606     +157     
==========================================
+ Hits         8888     9377     +489     
- Misses       1258     1361     +103     
- Partials     1372     1495     +123     
Impacted Files Coverage Δ
packages/s2-core/src/cell/merged-cell.ts 34.78% <ø> (-1.59%) ⬇️
packages/s2-core/src/common/constant/index.ts 90.47% <ø> (-0.60%) ⬇️
packages/s2-core/src/data-set/base-data-set.ts 93.54% <ø> (+25.80%) ⬆️
packages/s2-core/src/facet/header/row.ts 85.18% <0.00%> (ø)
...kages/s2-core/src/interaction/row-column-resize.ts 86.53% <0.00%> (ø)
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.11% <0.00%> (ø)
packages/s2-core/src/sheet-type/table-sheet.ts 89.65% <ø> (+1.72%) ⬆️
packages/s2-core/src/utils/hide-columns.ts 83.87% <ø> (+0.35%) ⬆️
packages/s2-core/src/utils/interaction/index.ts 95.23% <ø> (+0.59%) ⬆️
packages/s2-core/src/utils/merge.ts 90.32% <ø> (ø)
... and 164 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lijinke666 lijinke666 enabled auto-merge (squash) February 7, 2023 08:50
@lijinke666 lijinke666 merged commit 4602b42 into master Feb 8, 2023
@lijinke666 lijinke666 deleted the fix-icon-url branch February 8, 2023 02:42
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v1.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* fix: 自定义 svg 支持无后缀的在线链接

* test: 修复测试
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants