feat: tooltip summaries 返回原始数据 #2044

stone-lyl · 2023-01-11T09:22:57Z

👀 PR includes

✨ Feature

New feature

🎨 Enhance

🐛 Bugfix

Solve the issue and close #0

🔧 Chore

📝 Description

🖼️ Screenshot

添加原始数据的返回
当 name 为空时，不显示总和。

Before	After
❌	✅

🔗 Related issue link

🔍 Self-Check before the merge

Add or update relevant docs.
Add or update relevant demos.
Add or update test case.
Add or update relevant TypeScript definitions.

vercel · 2023-01-11T09:23:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
antvis-s2	❌ Failed (Inspect)		Jan 13, 2023 at 2:21AM (UTC)

github-actions · 2023-01-11T09:29:47Z

你好, @stone-lyl CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @stone-lyl CI run failed, please click the [Details] button for detailed log information and fix it.

github-actions · 2023-01-11T09:30:53Z

Size Change: +34 B (0%)

Total Size: 435 kB

Filename	Size	Change
`./packages/s2-core/dist/index.min.js`	171 kB	+15 B (0%)
`./packages/s2-react/dist/index.min.js`	67.4 kB	+19 B (0%)

ℹ️ View Unchanged

Filename	Size
`./packages/s2-core/dist/style.min.css`	389 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js`	21.7 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js`	21.2 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js`	60.3 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js`	33.9 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/config.js`	1.16 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js`	1.87 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js`	1.18 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/events.js`	1.55 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js`	300 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js`	738 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js`	810 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js`	1.07 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/index.js`	1.14 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js`	1.05 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js`	1.14 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js`	1.47 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js`	337 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js`	573 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js`	713 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js`	418 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js`	1.8 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js`	491 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js`	2.67 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js`	498 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js`	958 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js`	718 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js`	1.81 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js`	2.82 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js`	1.51 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js`	1.5 kB
`./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js`	748 B
`./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js`	2.38 kB
`./packages/s2-react/dist/style.min.css`	3.43 kB
`./packages/s2-vue/dist/index.min.js`	20.5 kB
`./packages/s2-vue/dist/style.min.css`	1.68 kB

_{compressed-size-action}

packages/s2-core/src/common/interface/tooltip.ts

codecov · 2023-01-12T09:02:29Z

Codecov Report

Base: 77.16% // Head: 76.67% // Decreases project coverage by -0.49% ⚠️

Coverage data is based on head (dab44c6) compared to base (a4b14a8).
Patch coverage: 66.63% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   77.16%   76.67%   -0.50%     
==========================================
  Files         234      240       +6     
  Lines       11518    12231     +713     
  Branches     2449     2609     +160     
==========================================
+ Hits         8888     9378     +490     
- Misses       1258     1362     +104     
- Partials     1372     1491     +119

Impacted Files	Coverage Δ
packages/s2-core/src/cell/merged-cell.ts	`34.78% <ø> (-1.59%)`	⬇️
packages/s2-core/src/common/constant/index.ts	`90.47% <ø> (-0.60%)`	⬇️
packages/s2-core/src/common/icons/gui-icon.ts	`86.66% <ø> (-1.71%)`	⬇️
packages/s2-core/src/data-set/base-data-set.ts	`93.54% <ø> (+25.80%)`	⬆️
packages/s2-core/src/facet/header/row.ts	`85.18% <0.00%> (ø)`
...kages/s2-core/src/interaction/row-column-resize.ts	`86.53% <0.00%> (ø)`
packages/s2-core/src/sheet-type/pivot-sheet.ts	`86.11% <0.00%> (ø)`
packages/s2-core/src/sheet-type/table-sheet.ts	`89.65% <ø> (+1.72%)`	⬆️
packages/s2-core/src/utils/hide-columns.ts	`83.87% <ø> (+0.35%)`	⬆️
packages/s2-core/src/utils/interaction/index.ts	`95.23% <ø> (+0.59%)`	⬆️
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lijinke666 · 2023-01-16T02:24:17Z

🎉 This PR is included in version @antv/s2-v1.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2023-01-16T02:27:35Z

🎉 This PR is included in version @antv/s2-react-v1.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2023-02-22T02:57:08Z

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2023-02-22T03:02:53Z

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

* feat: tooltip summaries 返回原始数据 * test: 测试格式化数据后，原始值和格式化的值差别 Co-authored-by: zishang <[email protected]>

feat: tooltip summaries 返回原始数据

f09530e

github-actions bot added the pr(feature) new feature label Jan 11, 2023

github-actions bot assigned stone-lyl Jan 11, 2023

github-actions bot requested review from GaoFuhong, lcx-seima, lijinke666, serializedowen, wjgogogo, xingwanying and YardWill January 11, 2023 09:23

github-actions bot added the 🚨 test failed 单元测试挂了 label Jan 11, 2023

wjgogogo reviewed Jan 12, 2023

View reviewed changes

packages/s2-core/src/common/interface/tooltip.ts Show resolved Hide resolved

test: 测试格式化数据后，原始值和格式化的值差别

76c4c97

vercel bot had a problem deploying to Preview January 12, 2023 08:10 Failure

github-actions bot removed the 🚨 test failed 单元测试挂了 label Jan 12, 2023

Merge branch 'master' into feat-tooltip-originalVal

dab44c6

vercel bot had a problem deploying to Preview January 13, 2023 02:21 Failure

wjgogogo approved these changes Jan 13, 2023

View reviewed changes

stone-lyl merged commit f8efdd9 into master Jan 13, 2023

stone-lyl deleted the feat-tooltip-originalVal branch January 13, 2023 09:11

lijinke666 added the released label Jan 16, 2023

lijinke666 added the released on @next label Feb 22, 2023

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023

feat: tooltip summaries 返回原始数据 (#2044)

a039b4e

* feat: tooltip summaries 返回原始数据 * test: 测试格式化数据后，原始值和格式化的值差别 Co-authored-by: zishang <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: tooltip summaries 返回原始数据 #2044

feat: tooltip summaries 返回原始数据 #2044

stone-lyl commented Jan 11, 2023 •

edited

Loading

vercel bot commented Jan 11, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 11, 2023 •

edited

Loading

codecov bot commented Jan 12, 2023 •

edited

Loading

lijinke666 commented Jan 16, 2023

lijinke666 commented Jan 16, 2023

lijinke666 commented Feb 22, 2023

lijinke666 commented Feb 22, 2023

feat: tooltip summaries 返回原始数据 #2044

feat: tooltip summaries 返回原始数据 #2044

Conversation

stone-lyl commented Jan 11, 2023 • edited Loading

👀 PR includes

📝 Description

🖼️ Screenshot

🔗 Related issue link

🔍 Self-Check before the merge

vercel bot commented Jan 11, 2023 • edited Loading

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 11, 2023 • edited Loading

codecov bot commented Jan 12, 2023 • edited Loading

Codecov Report

lijinke666 commented Jan 16, 2023

lijinke666 commented Jan 16, 2023

lijinke666 commented Feb 22, 2023

lijinke666 commented Feb 22, 2023

stone-lyl commented Jan 11, 2023 •

edited

Loading

vercel bot commented Jan 11, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2023 •

edited

Loading

codecov bot commented Jan 12, 2023 •

edited

Loading