Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bold字体对应数字字重不正确 #1841

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Conversation

lcx-seima
Copy link
Contributor

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

font-weight 定义bold 应对应 700 数字字重。
之前的 500 在 MacOS Chrome 下有粗体效果,但在 Safari 下没有。

🖼️ Screenshot

Before After
CleanShot 2022-10-21 at 14 58 34@2x CleanShot 2022-10-21 at 14 56 09@2x
CleanShot 2022-10-21 at 14 58 10@2x CleanShot 2022-10-21 at 14 56 49@2x

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 8:58AM (UTC)

xingwanying
xingwanying previously approved these changes Oct 21, 2022
Copy link
Member

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 430 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 168 kB
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 65.9 kB
./packages/s2-react/dist/style.min.css 3.32 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

@github-actions
Copy link
Contributor

你好, @lcx-seima CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lcx-seima CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 77.16% // Head: 77.11% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (515471a) compared to base (a4b14a8).
Patch coverage: 57.40% of modified lines in pull request are covered.

❗ Current head 515471a differs from pull request most recent head 5f9c663. Consider uploading reports for the commit 5f9c663 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   77.16%   77.11%   -0.06%     
==========================================
  Files         234      238       +4     
  Lines       11518    11711     +193     
  Branches     2449     2489      +40     
==========================================
+ Hits         8888     9031     +143     
- Misses       1258     1282      +24     
- Partials     1372     1398      +26     
Impacted Files Coverage Δ
...nteraction/brush-selection/base-brush-selection.ts 78.73% <ø> (+8.31%) ⬆️
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.11% <ø> (ø)
packages/s2-core/src/sheet-type/table-sheet.ts 87.93% <ø> (ø)
packages/s2-core/src/theme/index.ts 100.00% <ø> (ø)
packages/s2-core/src/utils/export/index.ts 73.63% <ø> (ø)
...ages/s2-core/src/utils/interaction/select-event.ts 93.61% <ø> (ø)
packages/s2-core/src/utils/text.ts 40.75% <ø> (ø)
...s2-react/src/components/tooltip/custom-tooltip.tsx 64.28% <ø> (-2.39%) ⬇️
packages/s2-shared/src/utils/drill-down.ts 21.31% <ø> (ø)
packages/s2-core/src/utils/g-mini-charts.ts 56.94% <11.11%> (+5.27%) ⬆️
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcx-seima lcx-seima enabled auto-merge (squash) October 21, 2022 08:49
@lcx-seima lcx-seima merged commit abe1607 into master Oct 21, 2022
@lcx-seima lcx-seima deleted the fix/theme-font-weight branch October 21, 2022 09:25
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* fix: bold字体对应数字字重不正确

* test: 修复失败的测试用例

* refactor: 优化代码
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants