Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 趋势表tooltip类名不再使用css-modules #1501

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

lcx-seima
Copy link
Contributor

@lcx-seima lcx-seima commented Jun 27, 2022

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

📝 Description

  • refactor: 为方便外部样式覆盖,趋势表 tooltip 不再使用 css-modules
  • fix: col tooltip value 样式未生效

🖼️ Screenshot

Before After
CleanShot 2022-06-27 at 20 40 53 CleanShot 2022-06-27 at 20 40 20

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

Size Change: -68 B (0%)

Total Size: 253 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 64.1 kB -51 B (0%)
./packages/s2-react/dist/style.min.css 3.36 kB -63 B (-2%)
./packages/s2-vue/dist/index.min.js 20.3 kB +46 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 163 kB
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-vue/dist/style.min.css 1.59 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

你好, @lcx-seima CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lcx-seima CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1501 (18f8138) into master (ce47db5) will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
+ Coverage   76.27%   76.33%   +0.05%     
==========================================
  Files         227      228       +1     
  Lines       10847    10866      +19     
  Branches     2244     2248       +4     
==========================================
+ Hits         8274     8295      +21     
  Misses       1313     1313              
+ Partials     1260     1258       -2     
Impacted Files Coverage Δ
...rategy-sheet/custom-tooltip/custom-col-tooltip.tsx 64.28% <33.33%> (+2.74%) ⬆️
...ategy-sheet/custom-tooltip/custom-data-tooltip.tsx 40.00% <50.00%> (+2.06%) ⬆️
...rategy-sheet/custom-tooltip/custom-row-tooltip.tsx 76.92% <66.66%> (+1.92%) ⬆️
packages/s2-shared/src/utils/classnames.ts 83.33% <80.00%> (ø)
...stom-tooltip/kpi-columns/custom-bullet-tooltip.tsx 45.83% <100.00%> (+2.35%) ⬆️
packages/s2-shared/src/constant/classnames.ts 100.00% <100.00%> (ø)
packages/s2-shared/src/index.ts 66.07% <100.00%> (+2.80%) ⬆️
packages/s2-core/src/facet/base-facet.ts 85.68% <0.00%> (+0.46%) ⬆️
...ckages/s2-core/src/interaction/event-controller.ts 82.73% <0.00%> (+0.80%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce47db5...18f8138. Read the comment docs.

@lijinke666
Copy link
Member

rebase 下 master, 有个测试挂了, master 修复了

@lcx-seima lcx-seima force-pushed the refactor/tooltip-theme branch from 2c4252d to 528e564 Compare June 28, 2022 02:17
@lcx-seima lcx-seima requested review from lijinke666 and wjgogogo June 28, 2022 11:40
@lcx-seima lcx-seima enabled auto-merge (squash) June 28, 2022 11:40
@lcx-seima lcx-seima disabled auto-merge June 28, 2022 11:40
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Jun 28, 2022
@xingwanying
Copy link
Member

u1s1, 这个动图属实是没看出来差别在哪里🧐

@xingwanying xingwanying merged commit 85d3637 into master Jun 28, 2022
@xingwanying xingwanying deleted the refactor/tooltip-theme branch June 28, 2022 16:05
lcx-seima added a commit that referenced this pull request Jun 29, 2022
@lcx-seima
Copy link
Contributor Author

u1s1, 这个动图属实是没看出来差别在哪里🧐

要的就是没差别呀,有问题就出事情了。LOL

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.21.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 pushed a commit that referenced this pull request Jul 6, 2022
* refactor: 趋势表tooltip类名不再使用css-modules

* refactor: 统一css类名前缀变量到shared
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* refactor: 趋势表tooltip类名不再使用css-modules

* refactor: 统一css类名前缀变量到shared
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants