Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interaction): 添加 onDataCellSelectMove 事件 #1468

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

zxc0328
Copy link
Member

@zxc0328 zxc0328 commented Jun 21, 2022

👀 PR includes

添加 onDataCellSelectMove 事件。在 selectMove 交互(键盘上下左右选择选中格子)触发时,抛出事件。用于需要外部 UI 和 selectMove 联动的场景。

@lijinke666
Copy link
Member

image

image

这里两个地方事件名加上 S2Event.DATE_CELL_SELECT_MOVE

@github-actions
Copy link
Contributor

Size Change: +61 B (0%)

Total Size: 246 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 162 kB +39 B (0%)
./packages/s2-react/dist/index.min.js 64.3 kB +9 B (0%)
./packages/s2-vue/dist/index.min.js 14.4 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 362 B
./packages/s2-react/dist/style.min.css 3.41 kB
./packages/s2-vue/dist/style.min.css 1.31 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1468 (0af92ac) into master (647470c) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   77.11%   76.81%   -0.31%     
==========================================
  Files         213      215       +2     
  Lines       10496    10742     +246     
  Branches     2164     2263      +99     
==========================================
+ Hits         8094     8251     +157     
- Misses       1204     1253      +49     
- Partials     1198     1238      +40     
Impacted Files Coverage Δ
...ages/s2-core/src/interaction/selected-cell-move.ts 80.70% <ø> (+0.17%) ⬆️
...ckages/s2-core/src/common/constant/events/basic.ts 100.00% <100.00%> (ø)
packages/s2-react/src/hooks/useEvents.ts 93.87% <100.00%> (+0.06%) ⬆️
...act/src/components/sheets/strategy-sheet/index.tsx 27.63% <0.00%> (-5.71%) ⬇️
...ategy-sheet/custom-tooltip/custom-data-tooltip.tsx 30.43% <0.00%> (-5.28%) ⬇️
...rategy-sheet/custom-tooltip/custom-row-tooltip.tsx 66.66% <0.00%> (-2.57%) ⬇️
...raction/base-interaction/click/row-column-click.ts 89.04% <0.00%> (-2.01%) ⬇️
...rc/components/sheets/strategy-sheet/utils/index.ts 64.28% <0.00%> (ø)
...stom-tooltip/kpi-columns/custom-bullet-tooltip.tsx 43.47% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1aef66...0af92ac. Read the comment docs.

Copy link
Member

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xingwanying xingwanying merged commit da2a78e into master Jun 21, 2022
@xingwanying xingwanying deleted the feat/selectMoveEvent branch June 21, 2022 11:55
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.22.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.20.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-vue-v1.1.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-vue-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* feat: 添加 selectmove 事件

* feat: 添加文档
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants