Revert "fix: 修复表格卸载时 G 图形实例未销毁的问题 (#2973)"

This reverts commit cc09af8.
antvis · Nov 14, 2024 · 65a58a6 · 65a58a6
1 parent 9007e8e
commit 65a58a6
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/s2-core/src/facet/base-facet.ts b/packages/s2-core/src/facet/base-facet.ts
@@ -828,14 +828,14 @@ export abstract class BaseFacet {
       const child = children[i];
 
       if (child instanceof Group) {
-        child.destroyChildren();
+        child.removeChildren();
       } else {
-        child.destroy();
+        children[i].remove();
       }
     }
 
-    this.foregroundGroup.destroyChildren();
-    this.backgroundGroup.destroyChildren();
+    this.foregroundGroup.removeChildren();
+    this.backgroundGroup.removeChildren();
   }
 
   scrollWithAnimation = (
@@ -1527,7 +1527,7 @@ export abstract class BaseFacet {
           (cell) => cell.name === `${i}-${j}`,
         );
 
-        mountedDataCell?.destroy();
+        mountedDataCell?.remove();
       });
 
       DebuggerUtil.getInstance().logger(