Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: site dev error & lodash ghost dependency #6543

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix: site dev error & lodash ghost dependency #6543

merged 1 commit into from
Dec 7, 2024

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Dec 7, 2024

issue
image image
Checklist
  • npm test passes
image
  • commit message follows commit guidelines
Description of change
  • Downgrade fmin version to fix development packaging issues
  • Solve the ghost dependency problem of lodash in site when using pnpm install

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12211226184

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.66%
Totals Coverage Status
Change from base Build 12194236144: 0.0%
Covered Lines: 10611
Relevant Lines: 11866
💛 - Coveralls

@hustcc hustcc merged commit 71fd89d into antvis:v5 Dec 7, 2024
2 checks passed
@hustcc hustcc mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BQXBQX @coveralls @hustcc