-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(label): implement label color inheritance from dependent elements #6536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the ability for labels to inherit colors from their associated graphical elements. This allows labels to automatically match the color of the elements they are describing. - Add style inheritance in label creation - Pass element style information to label callbacks - Add test case to verify the implementation
Pull Request Test Coverage Report for Build 12177125260Details
💛 - Coveralls |
hustcc
reviewed
Dec 5, 2024
hustcc
reviewed
Dec 5, 2024
另外,也帮忙改改文档中相关部分吧~ @BQXBQX |
- Remove Proxy usage in label style callback to prevent browser compatibility issues - Rename style parameter to elementStyle for better semantic clarity - Update documentation to clarify elementStyle parameter usage in label callbacks
hustcc
reviewed
Dec 5, 2024
hustcc
approved these changes
Dec 5, 2024
pearmini
reviewed
Dec 5, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the ability for labels to inherit colors from their associated graphical elements. This allows labels to automatically match the color of the elements they are describing.
Checklist
npm test
passesDescription of change
This PR implements the ability for labels to automatically inherit colors from their associated graphical elements in G2 charts.
Labels can now access and inherit styles from their dependent elements through the label callback's fourth parameter. This enables seamless color matching between labels and their graphical elements.