Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(label): correct label selector parameter handling and test case #6532

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Dec 3, 2024

Checklist
  • npm test passes
image
  • commit message follows commit guidelines
Description of change
  • Ensure label selector correctly filters data at specified index
  • Maintain consistent test behavior with original requirement

@hustcc
Copy link
Member

hustcc commented Dec 3, 2024

@hustcc hustcc requested a review from pearmini December 3, 2024 10:25
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12143367375

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.66%

Totals Coverage Status
Change from base Build 12135593436: 0.007%
Covered Lines: 10610
Relevant Lines: 11865

💛 - Coveralls

@hustcc hustcc self-requested a review December 3, 2024 11:08
@hustcc
Copy link
Member

hustcc commented Dec 3, 2024

tests/data/indices.json 这个文件是必须加的吗?看看当前仓库中是否有这个数据,我记得 demo 中是有用到这个数据 indices.csv。

@hustcc hustcc merged commit f8ce4ee into antvis:v5 Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants