Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update slider options #6530

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

justnewneo
Copy link
Contributor

@justnewneo justnewneo commented Nov 30, 2024

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

update the slider documentation that are already supported options but not shown in the docs.
For example:
To avoid label overlap, set autoFitLabel to false and add paddingRight to the chart
截屏2024-11-30 12 46 52

@hustcc
Copy link
Member

hustcc commented Dec 3, 2024

@justnewneo 单测已经修复:#6508 。可以重新 rebase 一下目标分支,在提交一下。

@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12143323051

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.653%

Totals Coverage Status
Change from base Build 12135593436: 0.0%
Covered Lines: 10610
Relevant Lines: 11865

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Dec 3, 2024

感谢 pr,去过有兴趣的话,可以按照 component 中的类型定义继续完善配置文档。

@hustcc hustcc merged commit b31a240 into antvis:v5 Dec 3, 2024
2 checks passed
@justnewneo justnewneo deleted the feature-slider-doc branch December 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants