feat: add columnWidthRatio configuration to the style of the interval #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11015658210Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
hustcc
reviewed
Sep 24, 2024
hustcc
reviewed
Sep 24, 2024
hustcc
requested changes
Sep 24, 2024
hustcc
approved these changes
Sep 24, 2024
pearmini
reviewed
Oct 16, 2024
Comment on lines
+5
to
+21
| export function columnWidthRatio<T extends G2ViewTree = G2ViewTree>( | ||
| options: T, | ||
| ): T { | ||
| const { style, scale, type } = options; | ||
| const scaleOption: G2View = {}; | ||
| const columnWidthRatio = get(style, 'columnWidthRatio'); | ||
| if (columnWidthRatio && type === 'interval') { | ||
| scaleOption.x = { | ||
| ...scale?.x, | ||
| padding: 1 - columnWidthRatio, | ||
| }; | ||
| } | ||
| return { | ||
| ...options, | ||
| scale: { ...scale, ...scaleOption }, | ||
| }; | ||
| } |
There was a problem hiding this comment.
这段逻辑更好是放在 transform 里面：这是 G2 提供的增加一些语法糖的内置机制，这样就不需要修改 runtime 的代码了。可以参考这个PR #5914
There was a problem hiding this comment.
好的，这个我下次做语法糖的时候看一下，看看需不需要迁移到transform里一起做
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6386
Checklist
npm testpassesDescription of change
add columnWidthRatio configuration to the style of the interval.
You can refer to the example below for usage.
example：
style: { columnWidthRatio: 0.2 } or .style('columnWidthRatio', 0.2)