Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltip markerType #6292

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Jun 15, 2024

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • 增加crosshairs上空心圆的设置,即markerType: "hollow"
    image

closed: #5999
closed: #6074

@coveralls
Copy link

coveralls commented Jun 15, 2024

Pull Request Test Coverage Report for Build 9525298246

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.423%

Totals Coverage Status
Change from base Build 9514194953: 0.007%
Covered Lines: 10392
Relevant Lines: 11647

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 15, 2024

Pull Request Test Coverage Report for Build 9529017088

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.423%

Totals Coverage Status
Change from base Build 9514194953: 0.007%
Covered Lines: 10392
Relevant Lines: 11647

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在案例中增加一个案例?可以把之前 crosshair 那个 PR 的案例也加上,给大家秀一秀 🤣

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在案例中增加一个案例?可以把之前 crosshair 那个 PR 的案例也加上,给大家秀一秀 🤣

@Runtus
Copy link
Contributor Author

Runtus commented Jun 17, 2024

在案例中增加一个案例?可以把之前 crosshair 那个 PR 的案例也加上,给大家秀一秀 🤣

好的,我这加一下

@pearmini
Copy link
Member

@Runtus 你案例截图发给我,我把它们上传之后,把链接给你。

@Runtus
Copy link
Contributor Author

Runtus commented Jun 17, 2024

@Runtus 你案例截图发给我,我把它们上传之后,把链接给你。

好的
十字辅助线:
image

空心圆:
image

@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9541988696

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.423%

Totals Coverage Status
Change from base Build 9514194953: 0.007%
Covered Lines: 10392
Relevant Lines: 11647

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@pearmini
Copy link
Member

@Runtus 我是指在 site/examples/component/tooltip 这里增加两个例子 🤣。不过这个 PR 我先合并了,你可以专门来一个 PR 添加例子。

@pearmini pearmini merged commit 2dd53ee into antvis:v5 Jun 17, 2024
2 checks passed
@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9544299865

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.423%

Totals Coverage Status
Change from base Build 9514194953: 0.007%
Covered Lines: 10392
Relevant Lines: 11647

💛 - Coveralls

@Runtus
Copy link
Contributor Author

Runtus commented Jun 17, 2024

@Runtus 我是指在 site/examples/component/tooltip 这里增加两个例子 🤣。不过这个 PR 我先合并了,你可以专门来一个 PR 添加例子。

不好意思,没get到点,我晚上改一下,今天有点忙哈哈哈所以思维有点乱🤣

@pearmini
Copy link
Member

@Runtus 没事没事,可能我没有说清楚,不着急哈😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants