Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): change the dark theme default background color to transparent #6226

Merged
merged 4 commits into from
May 9, 2024

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented May 9, 2024

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

@Runtus Runtus closed this May 9, 2024
@Runtus Runtus changed the title fix(theme): change fix(theme): change the dark theme default background color to transparent May 9, 2024
@Runtus Runtus reopened this May 9, 2024
@coveralls
Copy link

coveralls commented May 9, 2024

Pull Request Test Coverage Report for Build 9016723977

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.373%

Totals Coverage Status
Change from base Build 8998387105: 0.007%
Covered Lines: 10322
Relevant Lines: 11575

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented May 9, 2024

@Runtus 另外,官网主题 demo 中需要增加一行:

document.getElementById('container').style.background = '#141414';

@Runtus
Copy link
Contributor Author

Runtus commented May 9, 2024

CI好像挂了,我本地检查下啥情况

@hustcc
Copy link
Member

hustcc commented May 9, 2024

https://github.com/antvis/component/pull/318/files#diff-85d875b86904ac041094f85658fb11c5bc0ed6624d0967ae038b2edffd3cd522

可能是这里带来的,你本地删除截图,然后重新生成吧

@hustcc hustcc merged commit f444a74 into antvis:v5 May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.1.15: theme 'dark' applies black background color
3 participants