Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Axis-Theme): Translate Axis-Theme to En #5773

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Conversation

andylili21
Copy link
Contributor

@andylili21 andylili21 commented Nov 8, 2023

Issue: #5743

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

一些大小写问题注意一下

site/docs/manual/core/axis.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/composition.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/scrollbar.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/scrollbar.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/slider.en.md Outdated Show resolved Hide resolved
});
```

The slider can also be configured at the View level:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View -> view

site/docs/manual/core/legend.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/legend.en.md Outdated Show resolved Hide resolved
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearmini pearmini merged commit 45c0b14 into antvis:v5 Nov 10, 2023
2 checks passed
@pearmini pearmini mentioned this pull request Nov 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants