Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Transform): Translate transform to En #5759

Merged
merged 4 commits into from
Nov 10, 2023
Merged

docs(Transform): Translate transform to En #5759

merged 4 commits into from
Nov 10, 2023

Conversation

Zhizhi-2986
Copy link
Contributor

@Zhizhi-2986 Zhizhi-2986 commented Nov 7, 2023 •
edited
Loading

#5743

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

pearmini
pearmini requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 注意大小写问题：比如 Mark
  • 文中出现的 conversion 全部变成 transform

site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/transform.en.md Outdated Show resolved Hide resolved
@Zhizhi-2986
Copy link
Contributor Author

  • 注意大小写问题：比如 Mark
  • 文中出现的 conversion 全部变成 transform

好的，我注意一下

pearmini
pearmini requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

还剩下几个小问题！

site/docs/manual/core/animation.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/coordinate.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/coordinate.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/coordinate.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/coordinate.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/label.en.md Outdated Show resolved Hide resolved
pearmini
pearmini approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearmini pearmini merged commit d1e99fe into antvis:v5 Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhizhi-2986 @pearmini