Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto fit #5649

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: auto fit #5649

merged 1 commit into from
Oct 17, 2023

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Oct 17, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
Description of change

Fix the issue when autoFit is true and the container is lost height, the height config is not effect.

pearmini
pearmini requested changes Oct 17, 2023
View reviewed changes
src/api/utils.ts Outdated Show resolved Hide resolved
src/api/utils.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6544172629

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 88.171%
Totals Coverage Status
Change from base Build 6531247034: -0.002%
Covered Lines: 10041
Relevant Lines: 11025
💛 - Coveralls

@pearmini pearmini merged commit c9a0d90 into v5 Oct 17, 2023
3 checks passed
@pearmini pearmini deleted the fix/auto-fit branch October 17, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxfu1 @coveralls @pearmini