Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtinlib): move some components from core to builtinlib #5485

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Aug 30, 2023

把一些不会不会暴露给用户的组件放入 builtinlib,只供 runtime 使用。

export function builtinlib() {
  return {
    'component.axisRadar': AxisRadar,
    'component.axisLinear': AxisLinear,
    'component.axisArc': AxisArc,
    'component.legendContinuousBlock': LegendContinuousBlock,
    'component.legendContinuousBlockSize': LegendContinuousBlockSize,
    'component.legendContinuousSize': LegendContinuousSize,
    'interaction.event': Event,
    'composition.mark': Mark,
    'shape.label.label': LabelShape,
  } as const;
}

@pearmini pearmini requested a review from hustcc August 30, 2023 02:22
@pearmini pearmini force-pushed the feat/builtinlib branch 3 times, most recently from a13aa40 to 9018f4e Compare August 30, 2023 04:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6020986219

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 88.559%

Totals Coverage Status
Change from base Build 6020664144: 0.005%
Covered Lines: 9816
Relevant Lines: 10728

💛 - Coveralls

@pearmini pearmini merged commit fc70bf5 into v5 Aug 30, 2023
@pearmini pearmini deleted the feat/builtinlib branch August 30, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants