Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove this in selection #5468

Merged
merged 2 commits into from
Aug 25, 2023
Merged

refactor: remove this in selection #5468

merged 2 commits into from
Aug 25, 2023

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Aug 25, 2023

@hustcc hustcc force-pushed the refactor-remove-this-in-selection branch from 87ba97a to 8ecafb5 Compare August 25, 2023 07:49
@hustcc hustcc force-pushed the refactor-remove-this-in-selection branch from 8ecafb5 to 4475488 Compare August 25, 2023 09:31
@coveralls
Copy link

coveralls commented Aug 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5974651586

  • 38 of 38 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 88.76%
Totals Coverage Status
Change from base Build 5974251605: 0.001%
Covered Lines: 9787
Relevant Lines: 10682
💛 - Coveralls

pearmini
pearmini requested changes Aug 25, 2023
View reviewed changes
src/utils/selection.ts Outdated Show resolved Hide resolved
@hustcc hustcc merged commit 040767d into v5 Aug 25, 2023
@hustcc hustcc deleted the refactor-remove-this-in-selection branch August 25, 2023 13:29
@pearmini pearmini mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustcc @coveralls @pearmini