Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: label dom leak when chart re-render #5392

Merged
merged 4 commits into from
Aug 15, 2023
Merged

fix: label dom leak when chart re-render #5392

merged 4 commits into from
Aug 15, 2023

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Aug 14, 2023 •
edited
Loading

@hustcc hustcc force-pushed the fix-html-label-rerender branch from 6e66bd9 to 3659dec Compare August 15, 2023 02:04
@pearmini pearmini self-requested a review August 15, 2023 05:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5864805518

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.434%
Totals Coverage Status
Change from base Build 5831662019: 0.0%
Covered Lines: 9645
Relevant Lines: 10444
💛 - Coveralls

@hustcc hustcc merged commit 18e6626 into v5 Aug 15, 2023
@hustcc hustcc deleted the fix-html-label-rerender branch August 15, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

label.render option causes the font to become bold
4 participants
@hustcc @coveralls @pearmini @xiaoiver