-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart): autoFit do not set width and height of chart options #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pearmini
commented
Apr 27, 2023
- 问题:设置了 autoFit 之后,chart options 里的 width 和 height 会被设置。这样其实不太合理,应为用户并没有设置 width 和 height,拿到的 options 就和最开始的设置不同。
pearmini
force-pushed
the
fix/chart-auto-fit
branch
from
April 27, 2023 04:35
efea11c
to
7721c4b
Compare
ci解决一下,看起来没问题。我通过了。 |
pepper-nice
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
pearmini
force-pushed
the
fix/chart-auto-fit
branch
from
April 27, 2023 07:36
7721c4b
to
31b9786
Compare
pearmini
force-pushed
the
fix/chart-auto-fit
branch
from
April 27, 2023 07:43
31b9786
to
d49e72c
Compare
pearmini
force-pushed
the
fix/chart-auto-fit
branch
from
April 27, 2023 08:05
d49e72c
to
889f378
Compare
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.