Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mark): group animation options #4695

Merged
merged 1 commit into from
Feb 27, 2023
Merged

feat(mark): group animation options #4695

merged 1 commit into from
Feb 27, 2023

Conversation

pearmini
Copy link
Member

Animation

调整动画的配置方式,为了风格的统一和更好的扩展性。

开始使用

const before = {
  animate: { enterType: 'waveIn', enterDuration: 1000 },
};

const after = {
  animate: { enter: {type:'waveIn', duration: 1000} },
};

原因

但是拍平的原因是为了和 encode 里面保持统一,但是多了 mark.state API 之后,因为对不同的 state 增加动画,所以和 mark.state 的风格保持统一会更好一点。

const options = {
  animate: {
    active: { type: 'blink' },
  },
  state: {
    active: {},
  },
};

@pearmini pearmini requested review from hustcc and Aarebecca February 26, 2023 03:40
@pearmini pearmini force-pushed the refactor/mark-animate branch 2 times, most recently from 04e8599 to 9d2bfaa Compare February 26, 2023 04:35
@pearmini pearmini force-pushed the refactor/mark-animate branch from 9d2bfaa to 4381e76 Compare February 26, 2023 06:49
@pearmini pearmini merged commit fb56b62 into v5 Feb 27, 2023
@pearmini pearmini deleted the refactor/mark-animate branch February 27, 2023 06:20
Aarebecca pushed a commit that referenced this pull request Feb 27, 2023
Aarebecca pushed a commit that referenced this pull request Mar 1, 2023
hustcc pushed a commit that referenced this pull request May 16, 2023
hustcc pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants