Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加 Point #1583

Merged
merged 7 commits into from
Oct 28, 2019
Merged

添加 Point #1583

merged 7 commits into from
Oct 28, 2019

Conversation

simaQ
Copy link
Contributor

@simaQ simaQ commented Oct 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • All tests pass and/or benchmarks are included
  • Commit message follows commit guidelines
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@simaQ simaQ requested a review from hustcc October 28, 2019 07:57
@simaQ simaQ changed the title 添加 Point WIP: 添加 Point Oct 28, 2019
@auto-add-label auto-add-label bot added the WIP label Oct 28, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2019

This pull request fixes 2 alerts when merging e290619 into 6addd00 - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Unused variable, import, function or class

@simaQ simaQ changed the title WIP: 添加 Point 添加 Point Oct 28, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2019

This pull request fixes 2 alerts when merging 964c887 into 6addd00 - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Unused variable, import, function or class

@simaQ
Copy link
Contributor Author

simaQ commented Oct 28, 2019

点图的更新动画有点问题。详见 antvis/G#236

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2019

This pull request fixes 2 alerts when merging c4e6dd6 into 22f7e84 - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Unused variable, import, function or class

@@ -25,7 +27,7 @@ export default class Element {
/** 原始数据 */
public data: Datum;
/** shape 绘制数据 */
public model: ShapeModel;
public model: ShapeInfo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShapeModel -> ShapeInfo 的考虑是什么?

@hustcc hustcc removed the WIP label Oct 28, 2019
@hustcc hustcc merged commit 317b31b into 4.x Oct 28, 2019
@hustcc hustcc deleted the feat-point branch October 28, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants