New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Break Change] chart.node -> chart.getNode, chart.context -> chart.getContext #4685

Closed

pearmini opened this issue Feb 23, 2023 · 0 comments · Fixed by #4690

Assignees

Labels

V5

Milestone

Member

pearmini commented Feb 23, 2023

API 做以下调整：

chart.node() -> chart.getNode()
chart.context() -> chart.getContext()

在 G2 的 Chart API 非创建容器的约定如下：

chart.getXXX: getter
chart.xxx: getter and setter

基于此，所以需要调整。

pearmini assigned pepper-nice

pearmini added the V5 label

pearmini added this to G2

pearmini added this to the 5.0.0-beta.12 milestone

pearmini moved this to Todo in G2

pepper-nice added a commit that referenced this issue


          refactor(chart): rename context&node api to getContext and getNode (f…

53b77ca

…ixed: #4685)

pepper-nice added a commit that referenced this issue


          refactor(chart): rename context&node api to getContext and getNode (f…

11e092d

…ixed: #4685)

pearmini linked a pull request

that will close this issue

refactor(chart): rename context & node api to getContext and getNode (f… #4690

Merged

pearmini closed this as completed in #4690

pearmini pushed a commit that referenced this issue


          refactor(chart): rename context&node api to getContext and getNode (f…

dc52aae

…ixed: #4685) (#4690)

github-project-automation bot moved this from Todo to Done in G2

Aarebecca pushed a commit that referenced this issue


          refactor(chart): rename context&node api to getContext and getNode (f…

7977b9d

…ixed: #4685) (#4690)

hustcc pushed a commit that referenced this issue


          refactor(chart): rename context&node api to getContext and getNode (f…

efd2155

…ixed: #4685) (#4690)

hustcc pushed a commit that referenced this issue


          refactor(chart): rename context&node api to getContext and getNode (f…

aefe323

…ixed: #4685) (#4690)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment