Skip to content

Commit

Permalink
fix(dodgeX): do not update series channel if groupBy is invalid (#6344)
Browse files Browse the repository at this point in the history
* fix(dodgeX): do not update series channel if groupBy is invalid

* fix: ci
  • Loading branch information
pearmini authored Jul 3, 2024
1 parent 926fc69 commit 87c39da
Show file tree
Hide file tree
Showing 9 changed files with 1,557 additions and 331 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ const chart = new Chart({

// Specify visualization.
chart
.interval() // Create an interval mark and add it to the chart.
.data(data) // Bind data for this mark.
.encode('x', 'genre') // Assign genre column to x position channel.
.encode('y', 'sold') // Assign sold column to y position channel.
.encode('color', 'genre'); // Assign genre column to color channel.
.interval() // Create an interval mark and add it to the chart.
.data(data) // Bind data for this mark.
.encode('x', 'genre') // Assign genre column to x position channel.
.encode('y', 'sold') // Assign sold column to y position channel.
.encode('color', 'genre'); // Assign genre column to color channel.

// Render visualization.
chart.render();
Expand Down
1,251 changes: 1,251 additions & 0 deletions __tests__/integration/snapshots/static/mockIntervalSeriesOrder.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 87c39da

Please sign in to comment.