Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-canvas): clip animation should be effective #220

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • hasChanged should be updated after clip is drawn:
_applyClip(context, clip: ShapeBase) {
  if (clip) {
    clip.createPath(context);
    context.clip();
+   clip._afterDraw(); // clip 绘制完成后,需要缓存包围盒以及清除标记
  }
}

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix that clip animation is not effective. #218
🇨🇳 Chinese 🐞 [g-canvas] 修复裁剪动画不生效的问题。#218

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@dengfuping dengfuping changed the title fix(g-canvas): clip animation should be effective, close #218 fix(g-canvas): clip animation should be effective Oct 21, 2019
@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for antv-g ready!

Built with commit f0dbcfb

https://deploy-preview-220--antv-g.netlify.com

@dxq613 dxq613 merged commit 8d5864a into 4.x Oct 24, 2019
@dxq613 dxq613 deleted the fix-issue-218 branch October 24, 2019 07:35
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-canvas): clip animation should be effective
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants