fix: the size of an unloaded Image is 0 #1831
Merged
+50
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvisei
approved these changes
Nov 13, 2024
wang1212
added a commit
that referenced
this pull request
Nov 13, 2024
* fix: rough canvas rendering error (#1830) * fix: rough canvas rendering error * chore: add changeset * refactor: iterator forEach method now has compatibility * fix: the size of an unloaded Image is 0 (#1831) * Version Packages (#1832) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
The
srcproperty of the Image object of G allows passing awindow.Imageinstances without waiting for theonloadevent to complete. If the user does not explicitly specify thewidthandheight, the image will be rendered with a width and height of 0 pixels, resulting in rendering anomalies.💡 Background and solution
If the user sets the src attribute before the
onloadevent is triggered, G should render internally by listening to the onload event and obtaining the correct width and height attributes of thewindow.Imageinstance.📝 Changelog
☑️ Self Check before Merge