Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages/react-g package.json set peerDependencies react >= 16.13.1 #1824

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

renzhaoz
Copy link

@renzhaoz renzhaoz commented Nov 7, 2024

react-g peerDependencies react version is low!

πŸ€” This is a ...

  • New feature
  • [√ ] Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

πŸ’‘ Background and solution

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English
πŸ‡¨πŸ‡³ Chinese

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

react-g peerDependencies react version is low!
@renzhaoz renzhaoz changed the title Update package.json set peerDependencies react >= 16.13.1 Update packages/react-g package.json set peerDependencies react >= 16.13.1 Nov 7, 2024
@wang1212 wang1212 changed the base branch from next to release November 11, 2024 02:13
@wang1212
Copy link
Member

This is not a bug. We have not done sufficient testing on versions higher than v16, but we have not found any problems or received any feedback during use.

PR will be merged. Please report any problems you encounter during use.

@wang1212 wang1212 deleted the branch antvis:next November 11, 2024 02:34
@wang1212 wang1212 closed this Nov 11, 2024
@wang1212 wang1212 reopened this Nov 11, 2024
@renzhaoz
Copy link
Author

This is not a bug. We have not done sufficient testing on versions higher than v16, but we have not found any problems or received any feedback during use.

PR will be merged. Please report any problems you encounter during use.
react >=18. It not work normal. error will show in [email protected];

  1. when upgrade react-reconciler to [email protected].error still;
    error code line: var ReactSharedInternals = React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
    react18 instance have not this property __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.

  2. update react-reconciler to rc version . error still show in react-reconciler but not this error.

so, @antv/g6-extension-react depends on @antv/react-g just work normal when react version < 18;

@wang1212 wang1212 deleted the branch antvis:next November 13, 2024 10:57
@wang1212 wang1212 closed this Nov 13, 2024
@wang1212 wang1212 reopened this Nov 13, 2024
@wang1212 wang1212 changed the base branch from release to next November 14, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants