Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path elements are drawn incorrectly #1761

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: path elements are drawn incorrectly #1761

merged 2 commits into from
Aug 27, 2024

Conversation

wang1212
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #1760

💡 Background and solution

see #1760

The drawing command generation logic of the path element is abnormal. For the processing of the M command, redundant lineTo logic is added. Just remove the logic.

📝 Changelog

Language Changelog
🇺🇸 English fix: path elements are drawn incorrectly after using markerStartOffset (#1760)
🇨🇳 Chinese fix: path 元素在使用 markerStartOffset 后绘制异常

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hustcc hustcc merged commit 5e4a1d6 into release Aug 27, 2024
3 checks passed
@hustcc hustcc deleted the fix-1760 branch August 27, 2024 11:45
wang1212 added a commit that referenced this pull request Aug 30, 2024
* chore: add preview demo npm script

* fix: `path` elements are drawn incorrectly (#1761)

* fix: `path` elements are drawn incorrectly after using `markerStartOffset` (#1760)

* chore: revert package.json

* fix: html element's `getBounds` logic exception (#1743) (#1764)

* Version Packages (#1762)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants