Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dirty #1545

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Fix dirty #1545

merged 2 commits into from
Oct 8, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Oct 8, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xiaoiver xiaoiver merged commit 5e0de3d into release Oct 8, 2023
2 of 3 checks passed
@xiaoiver xiaoiver deleted the fix-dirty branch October 8, 2023 11:36
xiaoiver added a commit that referenced this pull request Oct 8, 2023
* Fix dirty (#1545)

* fix: disable render hooks in some renderer like webgl

* chore: commit changeset

* chore(release): bump version (#1546)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
renderingContext.dirtyRectangleRenderingDisabled =
this.disableDirtyRectangleRendering();

if (!canvasConfig.disableRenderHooks) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提供配置项用于跳过 render hooks,这样在 WebGL 渲染器中可以避免遍历整个场景树,造成大量开销。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant