Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use user-defined id in HTML #1184 #1483

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: use user-defined id in HTML #1184 #1483

merged 1 commit into from
Aug 14, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Aug 14, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1184

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xiaoiver xiaoiver merged commit 4ddca3e into release Aug 14, 2023
6 checks passed
@xiaoiver xiaoiver deleted the fix-1184 branch August 14, 2023 09:12
xiaoiver added a commit that referenced this pull request Aug 14, 2023
* fix: remove redundant data-id on HTML (#1479)

* fix: remove redundant data-id on HTML

* chore: commit changeset

* fix: use user-defined id in HTML #1184 (#1483)

* chore: commit changeset

* chore(release): bump version (#1480)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant