Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The webgl renderer reports an error when updating attributes of a Text element #1755

Closed
wang1212 opened this issue Aug 19, 2024 · 0 comments
Closed
Labels

Comments

@wang1212
Copy link
Member

When using the webgl renderer, the program occasionally fails when updating the properties of a Text type element.

This is because no boundary condition judgment is made in the program logic.

export class TextDrawcall extends Instanced {
  updateAttribute(
    objects: DisplayObject[],
    startIndex: number,
    name: string,
    value: any,
  ): void {
+   if (objects.length === 0) {
+      return;
+   }

     // ...
  }
}
wang1212 added a commit that referenced this issue Aug 19, 2024
@wang1212 wang1212 added the bug label Aug 19, 2024
wang1212 added a commit that referenced this issue Aug 22, 2024
wang1212 added a commit that referenced this issue Aug 22, 2024
* fix: fix g-react re-render (#1757)

* fix: render cache target to avoid rerender

* refactor: fix typo of reconciler

* fix: the logic boundary condition judgment of text element attribute update is missing (#1755) (#1756)

* chore: update changeset

* Version Packages (#1758)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Aaron <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant