Skip to content

Commit

Permalink
Fix line (#1589)
Browse files Browse the repository at this point in the history
* fix: ignore isBillboard for now

* chore: commit changeset
  • Loading branch information
xiaoiver authored Nov 16, 2023
1 parent 9bc34e8 commit 951bef3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/shaggy-monkeys-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@antv/g-plugin-device-renderer': patch
---

Cancel downgrading to Line.
4 changes: 2 additions & 2 deletions packages/g-plugin-device-renderer/src/renderer/Path.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class PathRenderer extends Batch {
// ];

getDrawcallCtors(object: DisplayObject) {
const { fill, stroke, opacity, strokeOpacity, lineWidth, isBillboard } =
const { fill, stroke, opacity, strokeOpacity, lineWidth } =
object.parsedStyle as ParsedPathStyleProps;
const hasStroke = stroke && !(stroke as CSSRGB).isNone;
const subpathNum = InstancedPathDrawcall.calcSubpathNum(object);
Expand All @@ -43,7 +43,7 @@ export class PathRenderer extends Batch {
!(strokeOpacity === 0 || opacity === 0 || lineWidth === 0 || !hasStroke)
) {
const isLine = InstancedLineDrawcall.isLine(object, i);
if (!isBillboard && isLine) {
if (isLine) {
drawcalls.push(InstancedLineDrawcall);
} else {
drawcalls.push(InstancedPathDrawcall);
Expand Down

0 comments on commit 951bef3

Please sign in to comment.