Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule realization for failure case too #51

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

reachjainrahul
Copy link
Contributor

With antrea 1.9, networkpolicystatus support realization status and error msg field. Added the backend support in Nephe too to report realization for both success and failure case.

Signed-off-by: Rahul Jain [email protected]

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #51 (5a386f8) into main (ecec19d) will increase coverage by 0.06%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   50.29%   50.36%   +0.06%     
==========================================
  Files          45       45              
  Lines        7008     7017       +9     
==========================================
+ Hits         3525     3534       +9     
  Misses       3098     3098              
  Partials      385      385              
Flag Coverage Δ
unit-tests 50.36% <89.28%> (+0.06%) ⬆️
Impacted Files Coverage Δ
pkg/controllers/cloud/networkpolicy_controller.go 50.70% <86.95%> (+1.77%) ⬆️
pkg/controllers/cloud/networkpolicy.go 69.17% <100.00%> (-0.13%) ⬇️

@reachjainrahul
Copy link
Contributor Author

/nephe-test-e2e-kind

Copy link
Contributor

@Anandkumar26 Anandkumar26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

With antrea 1.9, networkpolicystatus support realization status
and error msg field. Added the backend support in Nephe too to
report realization for both success and failure case.

Signed-off-by: Rahul Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants