fix aws dependency violation error #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Liu <[email protected]>
|
/nephe-test-e2e-all |
Signed-off-by: Alexander Liu <[email protected]>
Signed-off-by: Alexander Liu <[email protected]>
Signed-off-by: Alexander Liu <[email protected]>
|
/nephe-test-e2e-all |
reachjainrahul
approved these changes
Sep 21, 2022
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the dependency violation error for AWS. When ANP rule and addressGroup changes, cloud controller attempts to delete previous addressGroup before checking if the associated security rule in appliedToGroup is deleted. This result in a dependency violation error returned by AWS. The deletion eventually succeed on retry after the security rule is removed. This PR adds such security rule association and checks before deleting addressGroup, putting it into a pending state. No user behavior is changed
Changes
Signed-off-by: Alexander Liu [email protected]