Move VM CRD to VM Runtime Object #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
| serviceConfigs := accCfg.GetServiceConfigs() | ||
| for _, serviceConfig := range serviceConfigs { | ||
| if serviceConfig.getType() == CloudServiceTypeCompute { | ||
| resourceCRDs := serviceConfig.getResourceCRDs(namespace, accCfg.GetNamespacedName().String()) | ||
| computeCRDs = append(computeCRDs, resourceCRDs.virtualMachines...) | ||
| for _, vm := range resourceCRDs.virtualMachines { |
There was a problem hiding this comment.
We can create map inside getResourceCRDs itself.. Line 169 can be avoided.. @archanapholla can you make the change
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
reachjainrahul
commented
Mar 20, 2023
Anandkumar26
force-pushed
the
vmcrd
branch
3 times, most recently
from
df93005 to
1570022
Compare
reachjainrahul
commented
Mar 21, 2023
Anandkumar26
force-pushed
the
vmcrd
branch
2 times, most recently
from
17030af to
6ac2bfa
Compare
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
| namespace, _ := request.NamespaceFrom(ctx) | ||
| if namespace == "" { | ||
| objs = r.cloudInventory.GetAllVms() | ||
| } else if accountName != "" { |
There was a problem hiding this comment.
with new change, it should be cpa-name + cpa-namespace.. both label should be specified..
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
| r.pendingSyncCount-- | ||
| if r.pendingSyncCount == 0 { | ||
| GetControllerSyncStatusInstance().SetControllerSyncStatus(ControllerTypeVM) | ||
| // processEvent waits for any VM events and feeds the event to the |
There was a problem hiding this comment.
lets put 80 max character line for any comments
There was a problem hiding this comment.
Will make this as a standard going forward.
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
reachjainrahul
commented
Mar 28, 2023
| @@ -184,8 +184,11 @@ var _ = Describe(fmt.Sprintf("%s,%s: ExternalEntity", focusAws, focusAzure), fun | |||
| } | |||
| table.DescribeTable("Test ExternalEntity Life cycle", | |||
| func(kind string, hasNic, hasPort bool) { | |||
| // TODO: VM CRD is no longer present | |||
There was a problem hiding this comment.
@shenmo3 can you update the test similar to stale member test. Upon Ces and check if VM/EE is removed
Anandkumar26
force-pushed
the
vmcrd
branch
4 times, most recently
from
bf330f8 to
9131411
Compare
Depcreate VM CRD and move it to internal VM Runtime Object. Signed-off-by: Rahul Jain <[email protected]>
- Also sort imports - Update logging for the controller_sync_status.go - Fix lint errors Signed-off-by: Anand Kumar <[email protected]>
Signed-off-by: Alexander Liu <[email protected]>
- Also remove unwanted labels from VM object. - Add and update existing VMIndexers to use labels and new fields added in the vm status object. - Also update vpc label to use account namespaced name instead of using only the account name. Signed-off-by: Anand Kumar <[email protected]>
Signed-off-by: Alexander Liu <[email protected]>
- Elimimate CloudServiceResourceCRDs while fetching VirtualMachine objects from snapshot. - Add counters for add/update/delete in vm inventory. - Renamed functions/variables using the word vm CRD. - Eliminate member by member comparison for comparing vm objects from inventory with new objects created using cloud vm instances. Signed-off-by: Archana Holla <[email protected]>
vpc labels: cpa.name cpa.namespace vpc.name vm labels: cpa.name cpa.namespace region Also update rest implmentation to list objects based on label selector for vm and vpc. - Also remove vpc name from vm status field. - rename some vm status feilds - Also update vm inventory to use namespaced account name indexer Signed-off-by: Anand Kumar <[email protected]>
- Remove virtual machine crd form helm charts - Remove virtual machine crd from config Signed-off-by: Anand Kumar <[email protected]>
|
/nephe-test-e2e-kind |
|
/nephe-test-e2e-aks, /nephe-test-e2e-eks |
|
/nephe-test-e2e-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depcreate VM CRD and move it to internal VM Runtime Object.