Implement bundle APIs and corresponding command in Antctl #694

weiqiangt · 2020-05-08T02:33:02Z

Add system.antrea.tanzu.vmware.com/v1beta1/bundles API
on both agent APIServer and controller APIServer for
generating support bundles.
Add system.antrea.tanzu.vmware.com/v1beta1/bundles/download
for downloading bundles.
Add related unit tests and e2e tests.
Antctl Command for collecting bundles.

Resolves #703.

Signed-off-by: Weiqiang TANG [email protected]

antrea-bot · 2020-05-08T02:33:14Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-all: to trigger all tests.
/skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

tnqn

Haven't finished review yet

pkg/apis/system/v1beta1/types.go

pkg/apiserver/registry/system/bundle/dump.go

jianjuns

A general question on the design - if the bundle lifecycle is decided by the client, should we do REST like API and support create, delete, and get (download) against a single path like: /support-bundles/, instead of a separate path for downloading under: /support-bundles/download/?
@tnqn @edwardbadboy

test/e2e/bundle_test.go

pkg/apiserver/registry/system/bundle/dump.go

pkg/apis/system/v1beta1/types.go

jianjuns

Did not review all code yet, but two quick comments.

pkg/apis/system/v1beta1/types.go

pkg/ovs/vsctl/vsctl.go

pkg/agent/util/dump.go

pkg/apis/system/v1beta1/types.go

pkg/ovs/ovsctl/appctl.go

pkg/util/dump.go

pkg/apiserver/registry/system/bundle/rest.go

jianjuns · 2020-05-21T22:09:42Z

@weiqiangt @tnqn : are we able to get this one in 0.7.0?

jianjuns

Thanks for the update. I did not understand why there are two set of funcs for agent that implement the same functionalities. Could you check my question below?

pkg/agent/util/dump.go

pkg/agent/apiserver/handlers/bundle/handler.go

pkg/agent/util/dump_linux.go

weiqiangt · 2020-05-28T03:12:23Z

/test-all

pkg/antctl/raw/supportbundle/command.go

weiqiangt · 2020-05-28T03:46:32Z

/test-all

pkg/apiserver/registry/system/supportbundle/rest.go

pkg/ovs/ovsctl/vsctl.go

weiqiangt · 2020-05-28T05:26:22Z

/test-all

tnqn

LGTM

antoninbas

some typos I must have missed in my first review, along with one question

otherwise code LGTM, I think all my previous comments were addressed

pkg/antctl/raw/supportbundle/command.go

antoninbas · 2020-05-28T20:09:09Z

pkg/antctl/raw/supportbundle/command.go

+	kubeconfig.APIPath = "/apis"
+	kubeconfig.GroupVersion = &systemv1beta1.SchemeGroupVersion
+	kubeconfig.NegotiatedSerializer = scheme.Codecs.WithoutConversion()
+	kubeconfig.Insecure = true


@tnqn @weiqiangt
A bit of a last-minute question, is this only needed for the self-signed certificate case?

I'm afraid not. There is no server verification function in Antctl for now.

If antctl talks to kube-apiserver, it should use the K8s CA cert set in kubeconfig to verify kube-apiserver, and kube-apiserver will then start a new HTTPS request against antrea-controller and use CABundle in APIServices to verify it.
But support bundle command goes to antrea-controller and antrea-agent directly, we can probably read antrea-ca ConfigMap to verify antrea-controller, but we don't publish antrea-agent's self-signed cert yet, so no way to verify them for now.

Thanks a lot for the clarification @tnqn.

@weiqiangt / @tnqn do you think you could open an issue to track this? I don't know if you have a solution / long-term plan in mind already.

Just created one #758.

test/e2e/supportbundle_test.go

pkg/support/dump.go

Implement `antctl bundle` command for collecting bundle via CLI Signed-off-by: Weiqiang TANG <[email protected]>

antoninbas

LGTM

weiqiangt · 2020-05-29T05:44:31Z

/test-all

weiqiangt · 2020-05-29T05:57:32Z

/test-e2e

weiqiangt · 2020-05-29T05:58:47Z

/test-conformance

weiqiangt · 2020-05-29T06:14:09Z

/test-conformance

weiqiangt · 2020-05-29T06:14:18Z

/test-e2e

weiqiangt · 2020-05-29T06:14:27Z

/test-networkpolicy

lzhecheng · 2020-05-29T06:29:20Z

/test-conformance
/test-e2e
/test-networkpolicy

) - Add system.antrea.tanzu.vmware.com/v1beta1/bundles API on both agent APIServer and controller APIServer for generating support bundles. - Add system.antrea.tanzu.vmware.com/v1beta1/bundles/download for downloading bundles. - Add related unit tests and e2e tests. - An antctl command for collecting bundles. Resolves antrea-io#703. Signed-off-by: Weiqiang TANG <[email protected]>

- Add system.antrea.tanzu.vmware.com/v1beta1/bundles API on both agent APIServer and controller APIServer for generating support bundles. - Add system.antrea.tanzu.vmware.com/v1beta1/bundles/download for downloading bundles. - Add related unit tests and e2e tests. - An antctl command for collecting bundles. Resolves #703. Signed-off-by: Weiqiang TANG <[email protected]>

) - Add system.antrea.tanzu.vmware.com/v1beta1/bundles API on both agent APIServer and controller APIServer for generating support bundles. - Add system.antrea.tanzu.vmware.com/v1beta1/bundles/download for downloading bundles. - Add related unit tests and e2e tests. - An antctl command for collecting bundles. Resolves antrea-io#703. Signed-off-by: Weiqiang TANG <[email protected]>

weiqiangt added area/api Issues or PRs related to an API. size/XL Denotes a PR that changes 500+ lines, ignoring generated files. labels May 8, 2020

weiqiangt requested review from edwardbadboy, antoninbas, tnqn, mengdie-song and jianjuns May 8, 2020 02:33

vmwclabot added the cla-not-required label May 8, 2020

wenyingd force-pushed the weiqiangt/bundle-api branch from 52fa8c4 to e232a65 Compare May 8, 2020 04:12

weiqiangt force-pushed the weiqiangt/bundle-api branch from e232a65 to b54fc0b Compare May 8, 2020 04:40

tnqn reviewed May 11, 2020

View reviewed changes

pkg/apis/system/v1beta1/types.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/system/bundle/dump.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/system/bundle/dump.go Outdated Show resolved Hide resolved

jianjuns reviewed May 11, 2020

View reviewed changes

antoninbas reviewed May 14, 2020

View reviewed changes

test/e2e/bundle_test.go Outdated Show resolved Hide resolved

jianjuns reviewed May 18, 2020

View reviewed changes

weiqiangt force-pushed the weiqiangt/bundle-api branch 3 times, most recently from 11804ac to be9f7f2 Compare May 20, 2020 05:52

jianjuns reviewed May 21, 2020

View reviewed changes

pkg/apis/system/v1beta1/types.go Outdated Show resolved Hide resolved

pkg/ovs/vsctl/vsctl.go Outdated Show resolved Hide resolved

jianjuns reviewed May 21, 2020

View reviewed changes

pkg/agent/util/dump.go Outdated Show resolved Hide resolved

weiqiangt force-pushed the weiqiangt/bundle-api branch 2 times, most recently from 94db71f to c653212 Compare May 21, 2020 15:48

jianjuns reviewed May 21, 2020

View reviewed changes

pkg/apis/system/v1beta1/types.go Outdated Show resolved Hide resolved

pkg/ovs/ovsctl/appctl.go Outdated Show resolved Hide resolved

pkg/util/dump.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/system/bundle/rest.go Outdated Show resolved Hide resolved

weiqiangt force-pushed the weiqiangt/bundle-api branch 3 times, most recently from ab9a364 to bda9cf6 Compare May 22, 2020 10:23

jianjuns reviewed May 22, 2020

View reviewed changes

pkg/agent/util/dump.go Outdated Show resolved Hide resolved

pkg/agent/apiserver/handlers/bundle/handler.go Outdated Show resolved Hide resolved

weiqiangt force-pushed the weiqiangt/bundle-api branch from bda9cf6 to 120926a Compare May 23, 2020 07:59

jianjuns reviewed May 24, 2020

View reviewed changes

pkg/agent/util/dump_linux.go Outdated Show resolved Hide resolved

weiqiangt force-pushed the weiqiangt/bundle-api branch from c22891f to 39562f5 Compare May 28, 2020 03:06

jianjuns previously approved these changes May 28, 2020

View reviewed changes

pkg/antctl/raw/supportbundle/command.go Show resolved Hide resolved

tnqn reviewed May 28, 2020

View reviewed changes

pkg/apiserver/registry/system/supportbundle/rest.go Show resolved Hide resolved

pkg/apiserver/registry/system/supportbundle/rest.go Outdated Show resolved Hide resolved

pkg/ovs/ovsctl/vsctl.go Outdated Show resolved Hide resolved

weiqiangt dismissed jianjuns’s stale review via aeeb992 May 28, 2020 04:52

weiqiangt force-pushed the weiqiangt/bundle-api branch 2 times, most recently from aeeb992 to 62aaaac Compare May 28, 2020 05:24

tnqn previously approved these changes May 28, 2020

View reviewed changes

antoninbas reviewed May 28, 2020

View reviewed changes

antoninbas added this to the Antrea v0.7.0 release milestone May 28, 2020

Implement support bundle command

1472d24

Implement `antctl bundle` command for collecting bundle via CLI Signed-off-by: Weiqiang TANG <[email protected]>

weiqiangt dismissed tnqn’s stale review via 1472d24 May 29, 2020 01:50

weiqiangt force-pushed the weiqiangt/bundle-api branch from 62aaaac to 1472d24 Compare May 29, 2020 01:50

antoninbas approved these changes May 29, 2020

View reviewed changes

weiqiangt merged commit 2e084e0 into antrea-io:master May 29, 2020

antoninbas mentioned this pull request Jun 8, 2020

Ability to easily collect all the relevant information when submitting bug report #11

Closed

weiqiangt deleted the weiqiangt/bundle-api branch December 24, 2020 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement bundle APIs and corresponding command in Antctl #694

Implement bundle APIs and corresponding command in Antctl #694

weiqiangt commented May 8, 2020 •

edited

Loading

antrea-bot commented May 8, 2020

tnqn left a comment

jianjuns left a comment

jianjuns left a comment

jianjuns commented May 21, 2020

jianjuns left a comment

weiqiangt commented May 28, 2020

weiqiangt commented May 28, 2020

weiqiangt commented May 28, 2020

tnqn left a comment

antoninbas left a comment

antoninbas May 28, 2020

weiqiangt May 29, 2020

tnqn May 29, 2020

antoninbas May 29, 2020

weiqiangt May 29, 2020

antoninbas left a comment

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

lzhecheng commented May 29, 2020

Implement bundle APIs and corresponding command in Antctl #694

Implement bundle APIs and corresponding command in Antctl #694

Conversation

weiqiangt commented May 8, 2020 • edited Loading

antrea-bot commented May 8, 2020

tnqn left a comment

Choose a reason for hiding this comment

jianjuns left a comment

Choose a reason for hiding this comment

jianjuns left a comment

Choose a reason for hiding this comment

jianjuns commented May 21, 2020

jianjuns left a comment

Choose a reason for hiding this comment

weiqiangt commented May 28, 2020

weiqiangt commented May 28, 2020

weiqiangt commented May 28, 2020

tnqn left a comment

Choose a reason for hiding this comment

antoninbas left a comment

Choose a reason for hiding this comment

antoninbas May 28, 2020

Choose a reason for hiding this comment

weiqiangt May 29, 2020

Choose a reason for hiding this comment

tnqn May 29, 2020

Choose a reason for hiding this comment

antoninbas May 29, 2020

Choose a reason for hiding this comment

weiqiangt May 29, 2020

Choose a reason for hiding this comment

antoninbas left a comment

Choose a reason for hiding this comment

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

weiqiangt commented May 29, 2020

lzhecheng commented May 29, 2020

weiqiangt commented May 8, 2020 •

edited

Loading