Automated cherry pick of #6696: More robust system Tier creation / update (#6696) #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
the
kind/cherry-pick
This comment was marked as outdated.
This comment was marked as outdated.
System Tier initialization should ideally wait for the Tier informer's cache to sync before using the lister. Otherwise we may think that the system Tiers have not been created yet when in fact it is just the informer that has not completed the initial List operation. Additionally, we improve the logic in system Tier initialization: * After every failed API call, we should probably check the state of the informer cache again (via the lister) and decide which step is needed next (creation / update / nothing). In case of a failed create or update, this gives us the opportunity to check again if the Tier actually exists, and if yes, what its priority is. * AlreadyExists is no longer treated differently for create. The reason is that if the Tier already exists and for some reason it was not returned by the Lister, it will probably be the validation webhook that fails (overlapping priority), and the error won't match AlreadyExists. Related to antrea-io#6694 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
automated-cherry-pick-of-#6696-upstream-release-2.1
branch
from
de301cf
to
6f4b170
Compare
This comment was marked as outdated.
This comment was marked as outdated.
antoninbas
commented
Oct 8, 2024
| @@ -320,7 +321,13 @@ func installHandlers(c *ExtraConfig, s *genericapiserver.GenericAPIServer) { | |||
|
|
|||
| // Install a post start hook to initialize Tiers on start-up | |||
| s.AddPostStartHook("initialize-tiers", func(context genericapiserver.PostStartHookContext) error { | |||
| go c.networkPolicyController.InitializeTiers() | |||
| ctx := wait.ContextForChannel(context.StopCh) | |||
There was a problem hiding this comment.
This is the difference with the original commit 4edb5ec
luolanzone
approved these changes
Oct 9, 2024
Yes I'm working on backporting it to 2.0 and 1.15. I started with this PR only because it wasn't a "clean" backport. |
|
/test-kind-all |
|
/test-all |
1 similar comment
|
/test-all |
antoninbas
deleted the
automated-cherry-pick-of-#6696-upstream-release-2.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #6696 on release-2.1.
#6696: More robust system Tier creation / update (#6696)
For details on the cherry pick process, see the cherry pick requests page.